Change in osmo-bsc[master]: a_reset: cleanup + remove dead code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Tue May 15 11:27:34 UTC 2018


Hello Neels Hofmeyr, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/8055

to look at the new patch set (#3).

Change subject: a_reset: cleanup + remove dead code
......................................................................

a_reset: cleanup + remove dead code

The function a_reset_free() is not used anywhere at the code. The
reason for this is that a BSC instance is never cleared once it
is started up. Also the timer number is not according to the spec.

- Remove a_reset_free()
- Fix timer identification number (T4)
- use fi->priv to hold context info
- Fix sourcecode formatting

Change-Id: I72095d52304c520e383755eee6c889bce492cbd4
Related: OS#3102
---
M include/osmocom/bsc/a_reset.h
M include/osmocom/bsc/bsc_msc_data.h
M src/libbsc/a_reset.c
M src/libbsc/bsc_subscr_conn_fsm.c
M src/osmo-bsc/osmo_bsc_api.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/osmo_bsc_sigtran.c
7 files changed, 77 insertions(+), 105 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/55/8055/3
-- 
To view, visit https://gerrit.osmocom.org/8055
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I72095d52304c520e383755eee6c889bce492cbd4
Gerrit-Change-Number: 8055
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180515/e6ce283a/attachment.htm>


More information about the gerrit-log mailing list