[PATCH] osmo-trx[master]: trx_vty.c: fix: use CONFIG_NODE as parent by default

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed May 9 08:58:52 UTC 2018


Review at  https://gerrit.osmocom.org/8083

trx_vty.c: fix: use CONFIG_NODE as parent by default

There are some configuration nodes, which are handled by extenral
libraries, such as libosmoctrl. So, when switching back to the
parent node, this should be kept in mind.

Instead of aborting, let's got to the CONFIG_NODE by default.

Fixes: OS#3250
Change-Id: Ia0600a46d19825806e5aed9257b6c57c3907808b
---
M CommonLibs/trx_vty.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/83/8083/1

diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c
index 843d19f..e69df77 100644
--- a/CommonLibs/trx_vty.c
+++ b/CommonLibs/trx_vty.c
@@ -503,7 +503,9 @@
 		vty->index_sub = NULL;
 		break;
 	default:
-		OSMO_ASSERT(0);
+		vty->node = CONFIG_NODE;
+		vty->index = NULL;
+		vty->index_sub = NULL;
 	}
 
 	return vty->node;

-- 
To view, visit https://gerrit.osmocom.org/8083
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0600a46d19825806e5aed9257b6c57c3907808b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>



More information about the gerrit-log mailing list