[PATCH] osmo-bts[master]: ip.access dyn ts: properly NACK a PDCH ACT on a still active...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue May 8 20:15:05 UTC 2018


Review at  https://gerrit.osmocom.org/8080

ip.access dyn ts: properly NACK a PDCH ACT on a still active lchan

Fixes: BTS_Tests.TC_dyn_ipa_pdch_tchf_act_pdch_act_nack
Change-Id: I12816ef9953467decd9f745217135702a544c8fc
---
M src/common/rsl.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/80/8080/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index c3e9604..902b68f 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2115,6 +2115,13 @@
 		return;
 	}
 
+	if (lchan->state != LCHAN_S_NONE) {
+		LOGP(DRSL, LOGL_ERROR,
+		     "%s Request to PDCH %s, but lchan is still active\n",
+		     gsm_ts_and_pchan_name(ts), pdch_act? "ACT" : "DEACT");
+		rsl_tx_dyn_pdch_nack(lchan, pdch_act, RSL_ERR_NORMAL_UNSPEC);
+	}
+
 	ts->flags |= pdch_act? TS_F_PDCH_ACT_PENDING
 			     : TS_F_PDCH_DEACT_PENDING;
 

-- 
To view, visit https://gerrit.osmocom.org/8080
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I12816ef9953467decd9f745217135702a544c8fc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list