libosmo-sccp[master]: free local variable 'prim' in lm_timer_cb() of lm_fsm

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue May 8 15:41:47 UTC 2018


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/8065/1/src/xua_default_lm_fsm.c
File src/xua_default_lm_fsm.c:

Line 188: 		msgb_free(prim->oph.msg);
Actually, this is wrong as per the general convention on how osmo_prim based SAPs behave.  The primitive ownership is passed from the SAP provider (which we are here) to the SAP consumer.  It's the responsibility of the XLM (xUA layer manager) to process / consume / release the primitive.


-- 
To view, visit https://gerrit.osmocom.org/8065
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie667b1b8beeda2aa4520a1413f51101435215cc0
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list