osmo-msc[master]: a_reset: cleanup + remove dead code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon May 7 13:35:30 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/8054/1/src/libmsc/a_reset.c
File src/libmsc/a_reset.c:

Line 126: 	reset->fsm->priv = reset;
ah, my bad, fsm->priv is actually set here. But rather use the priv arg of osmo_fsm_inst_alloc(), and rather decide on using priv or using the event data pointer, not both. (I'd favor fi->priv)


-- 
To view, visit https://gerrit.osmocom.org/8054
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e489eb494d358d130e51cb2167929edeaa12e92
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list