osmo-ttcn3-hacks[master]: make PCU tests send PS paging requests on BVCI zero

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon May 7 10:11:13 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/8020/1/library/BSSGP_Emulation.ttcn
File library/BSSGP_Emulation.ttcn:

Line 538: 	[] BSSGP_SP.receive(tr_BSSGP_PS_PAGING(0)) -> value bs_pdu sender vc_conn {
> I would argue this template should match all BSSGP messages for BVCI=0 (sig
This sounds like a good idea but I don't see an obvious way of achieving it. What is the easiest way to achieve a match on any BSSGP PDU with BCVCI == 0?

PDU_BSSGP is a union which overlays several types of BSSGP PDUs. If every such PDU had a common 'bvci' field to match on this would be trivial. But as far as I can tell, the location and name of the BVCI value may differ between various PDUs represented in this union. For example, in paging-related PDUs the BVCI is part of a Paging_Field4 subfield. The FLUSH_LL message type even has two BVCI fields (bVCI_old and bVCI_new).

Do I need to add a separate .receive() case here, for each specific BSSGP PDU type of interest?

Or could I write a function which returns returns true or false depending on whether a specific type of PDU belongs to a signaling or PTP virtual connection? This could probably cover most messages except the paging messages which can use either type of virtual connection.


-- 
To view, visit https://gerrit.osmocom.org/8020
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0437123b04b7320a4f690f0646578c57abf6bc87
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list