[MERGED] osmo-pcu[master]: improve documentation of Encoding::write_paging_request()

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: improve documentation of Encoding::write_paging_request()
......................................................................


improve documentation of Encoding::write_paging_request()

Add pointers to relevant parts of the spec. Tweak comments to be
more specific about the values being written and abbreviations used.

Change-Id: Ia5bf3f7f8846198b7b4e25ff1accf6206764be74
---
M src/encoding.cpp
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/encoding.cpp b/src/encoding.cpp
index b2da1e8..1f96458 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -609,7 +609,7 @@
 	pda_r99->Exist_COMPACT_ReducedMA = 0;
 }
 
-/* generate paging request */
+/* Generate paging request. See 44.018, sections 10 and 9.1.22 */
 int Encoding::write_paging_request(bitvec * dest, uint8_t *ptmsi, uint16_t ptmsi_len)
 {
 	unsigned wp = 0;
@@ -617,7 +617,7 @@
 
 	bitvec_write_field(dest, &wp,0x0,4);  // Skip Indicator
 	bitvec_write_field(dest, &wp,0x6,4);  // Protocol Discriminator
-	bitvec_write_field(dest, &wp,0x21,8); // Paging Request Message Type
+	bitvec_write_field(dest, &wp,0x21,8); // Paging Request Message Type 1
 
 	bitvec_write_field(dest, &wp,0x0,4);  // Page Mode
 	bitvec_write_field(dest, &wp,0x0,4);  // Channel Needed
@@ -636,7 +636,7 @@
 			       "multiple of 8 bits, PLEASE FIX!\n");
 
 	plen = wp / 8;
-	bitvec_write_field(dest, &wp,0x0,1); // "L" NLN(PCH) = off
+	bitvec_write_field(dest, &wp,0x0,1); // "L" Notification List Number; NLN(PCH) = off
 	bitvec_write_field(dest, &wp,0x0,1); // "L" Priority1 = off
 	bitvec_write_field(dest, &wp,0x1,1); // "L" Priority2 = off
 	bitvec_write_field(dest, &wp,0x0,1); // "L" Group Call information = off

-- 
To view, visit https://gerrit.osmocom.org/7962
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5bf3f7f8846198b7b4e25ff1accf6206764be74
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder