libosmocore[master]: lapdm: Implement SABM related constraints

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Tue May 1 17:06:50 UTC 2018


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/7960/1/src/gsm/lapdm.c
File src/gsm/lapdm.c:

Line 545: 		if (lctx->format == LAPD_FORM_U && lctx->s_u == LAPD_U_SABM) {
May we unpack this condition in the following way:

if (lctx->format == LAPD_FORM_U && lctx->s_u == LAPD_U_SABM) {
  if (le->mode == LAPDM_MODE_BTS) {
    // ...
  } else if (le->mode == LAPDM_MODE_MS) {
    // ...
  }
}


Line 708: 		rc =lapdm_rx_not_permitted(le, &lctx);
's/ =/ = /'


-- 
To view, visit https://gerrit.osmocom.org/7960
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c2c103cdc7f9a45d7b2080c572f559fc3db58e4
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list