This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 5: Code-Review+2 (2 comments) I'll save my nitpicking for more important issues... https://gerrit.osmocom.org/#/c/7405/4/bsc/regen_makefile.sh File bsc/regen_makefile.sh: Line 14: ln -s build/BSC_Tests ../BSC_Tests || true > > It is useful to be able to run older versions of osmo-ttcn3-hacks in the I guess I'd have done it the other way round but ok :) https://gerrit.osmocom.org/#/c/7405/4/gen_links.sh.inc File gen_links.sh.inc: Line 17: for f in $FILES; do > Even if it makes the commit smaller, given that I already did the work and given that it adds a lot of bloat I would prefer a smaller patch instead. In general, if a patch can be smaller, it will for all the future make the git history easier to follow and gives less trouble when work with patches. Not so critical here, that's my opinion but I won't block on this. -- To view, visit https://gerrit.osmocom.org/7405 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c Gerrit-PatchSet: 5 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-HasComments: Yes