This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPatch Set 4: (4 comments) https://gerrit.osmocom.org/#/c/7405/4/bsc/regen_makefile.sh File bsc/regen_makefile.sh: Line 14: ln -s build/BSC_Tests ../BSC_Tests || true > My first reflex is to not want this around. > It is useful to be able to run older versions of osmo-ttcn3-hacks in the same docker-playground. Really? are we doing that? I don't think so given how we improved the ttcn3 tests over time. It'd made more sense the opposite and still we don't do tat. My plan is to keep those links there for now and then once this merged and running fine, modify docker-playground scripts to use the build/Foo_Test instead of Foo_Test, then we can drop the symlinks here. https://gerrit.osmocom.org/#/c/7405/4/gen_links.sh.inc File gen_links.sh.inc: Line 11: echo "$f" >> .gitignore > -1: All .gitignore related stuff is now no longer needed, remove this. It w Ack, I'll remove it. Line 17: DSTDIR=$1 > -0: it's always "./build/", isn't it? The patch would be a lot smaller if w Even if it makes the commit smaller, given that I already did the work and that it provides more flexibility, I'd leave it as it is. https://gerrit.osmocom.org/#/c/7405/4/sgsn/regen_makefile.sh File sgsn/regen_makefile.sh: Line 14: ln -s build/SGSN_Tests ../SGSN_Tests || true > Yes, it's correct, but I still think it would be nice to have only one plac Let's first merge this one, then change docker-playground to use build/Foo_test, then drop the symlinks. -- To view, visit https://gerrit.osmocom.org/7405 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9ca176869ce6b80ccf2b2fff6554b121e1aa85c Gerrit-PatchSet: 4 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-HasComments: Yes