osmo-bsc[master]: paging: paging_request_bts: Fix wrong return value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Mar 26 17:05:39 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7510/1/src/libbsc/paging.c
File src/libbsc/paging.c:

Line 345: 		return 0;
> why not handle the negative rc properly at the callers?
Because the behaviour was changed recently by stsp in all those functions while refactoring the code afaik, so you can better discuss it with him.
I personally prefer typical C style (0 success, negative error) unless it's a function returning a "bool" type and it's clearly a true/false thing.


-- 
To view, visit https://gerrit.osmocom.org/7510
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48f5efbcddd98e15256edfca06ba0ae6acb5bab1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list