This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged.
Change subject: contrib/fsm-to-dot: add default edge label '-'
......................................................................
contrib/fsm-to-dot: add default edge label '-'
When some edges have no label, it is sometimes hard to interpret which label
belongs to which edge. Adding a '-' default label clarifies the edge labeling.
Change-Id: I3a10b615288107e8fc12ffdbbe0099cf51abe94f
---
M contrib/fsm-to-dot.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/contrib/fsm-to-dot.py b/contrib/fsm-to-dot.py
index 7a4694e..872577e 100755
--- a/contrib/fsm-to-dot.py
+++ b/contrib/fsm-to-dot.py
@@ -532,7 +532,10 @@
if out_edge.actions:
labels.extend(out_edge.action_labels())
if labels:
- attrs.append('label="%s"' % (r'\n'.join(labels)))
+ label = r'\n'.join(labels)
+ else:
+ label = '-'
+ attrs.append('label="%s"' % label)
if out_edge.style:
attrs.append('style=%s'% out_edge.style)
if out_edge.color:
--
To view, visit https://gerrit.osmocom.org/7498
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a10b615288107e8fc12ffdbbe0099cf51abe94f
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>