osmo-bsc[master]: cosmetic: remove dead code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Mar 23 20:26:34 UTC 2018


Patch Set 1: Code-Review-1

(1 comment)

approved, except the comment doesn't fit

https://gerrit.osmocom.org/#/c/7428/1/src/osmo-bsc/osmo_bsc_msc.c
File src/osmo-bsc/osmo_bsc_msc.c:

Line 56: 	 * to 1 by default. */
sounds like rather osmo_bsc_filter.c should query the proper places for is_connected and is_authenticated flags. BTW, in osmo-bsc we don't really know "is_authenticated", we just know the MSC is carrying on with the connection. I accept that this is an issue independent from this patch, so maybe the comment should not be part of this patch, and, for lack of a proper fix, we should have a separate redmine issue on this.


-- 
To view, visit https://gerrit.osmocom.org/7428
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cf3fec31cc774c902f3cfe6d16fb85ef301694a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list