osmo-bts[master]: octphy: integrate octasics latest header release

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Mar 23 19:33:40 UTC 2018


Patch Set 1: Code-Review+1

(8 comments)

https://gerrit.osmocom.org/#/c/7487/1//COMMIT_MSG
Commit Message:

Line 10: file relase from OCTSDR-2G-02.10.00-B1837-ALPHA as there are
it's almost like "relase" should be an actual word, sounds like "re-heat with a laser"


Line 22: Patch by Octasic inc.
There's a tag convention:

  Patch-by: Name

(to join Change-Id: and Related: below)


https://gerrit.osmocom.org/#/c/7487/1/configure.ac
File configure.ac:

Line 154: 
was this moved? commit log talks only of "Add"


Line 219: 			AC_DEFINE([OCTPHY_USE_CLOCK_SYNC_MGR_STATS_SYNC_LOSSE_CNT],
really "LOSSE"? :)


Line 225: 	AC_CHECK_MEMBER([tOCTVC1_HW_MSG_CLOCK_SYNC_MGR_STATS_RSP.ulSyncLossCnt],
(ah here it is from above)


https://gerrit.osmocom.org/#/c/7487/1/src/osmo-bts-octphy/octphy_hw_api.c
File src/osmo-bts-octphy/octphy_hw_api.c:

Line 295: 	    (tOCTVC1_HW_MSG_CLOCK_SYNC_MGR_INFO_RSP *) resp->l2h;
omit this whitespace change? (same below)


Line 381: 	get_cb_data = (struct octphy_hw_get_cb_data *)data;
different kind of whitespace change


https://gerrit.osmocom.org/#/c/7487/1/src/osmo-bts-octphy/octphy_vty.c
File src/osmo-bts-octphy/octphy_vty.c:

Line 265: 	struct vty *vty = (struct vty *)data;
ws


-- 
To view, visit https://gerrit.osmocom.org/7487
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic38d8dc35522205c4ffab583b4e61b5ef03cdba2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list