[MERGED] osmo-msc[master]: rename libcommon to libgsupclient

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 22 17:27:45 UTC 2018 

Harald Welte has submitted this change and it was merged.

Change subject: rename libcommon to libgsupclient
......................................................................


rename libcommon to libgsupclient

All that is left in libcommon now are the GSUP and OAP client implementations.
These are duplicated in osmo-sgsn.git and make sense to remain somewhat
separate from libmsc. So now they get their own little lib.

Change-Id: Ic71aa119c233b6a0ae169a5b2a53819903d2be82
---
M configure.ac
M src/Makefile.am
R src/libgsupclient/Makefile.am
R src/libgsupclient/gsup_client.c
R src/libgsupclient/gsup_test_client.c
R src/libgsupclient/oap_client.c
M src/osmo-msc/Makefile.am
M src/utils/Makefile.am
M tests/db/Makefile.am
M tests/msc_vlr/Makefile.am
M tests/smpp/Makefile.am
M tests/sms_queue/Makefile.am
12 files changed, 8 insertions(+), 13 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index e8ae88c..3d00282 100644
--- a/configure.ac
+++ b/configure.ac
@@ -206,7 +206,7 @@
     src/Makefile
     src/libmsc/Makefile
     src/libvlr/Makefile
-    src/libcommon/Makefile
+    src/libgsupclient/Makefile
     src/libcommon-cs/Makefile
     src/osmo-msc/Makefile
     src/utils/Makefile
diff --git a/src/Makefile.am b/src/Makefile.am
index b03ee8c..32bd4d7 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -21,7 +21,7 @@
 
 # Libraries
 SUBDIRS = \
-	libcommon \
+	libgsupclient \
 	libvlr \
 	libmsc \
 	libcommon-cs \
diff --git a/src/libcommon/Makefile.am b/src/libgsupclient/Makefile.am
similarity index 83%
rename from src/libcommon/Makefile.am
rename to src/libgsupclient/Makefile.am
index fdd967f..a33fb38 100644
--- a/src/libcommon/Makefile.am
+++ b/src/libgsupclient/Makefile.am
@@ -10,16 +10,14 @@
 	$(LIBOSMOGSM_CFLAGS) \
 	$(LIBOSMOVTY_CFLAGS) \
 	$(LIBOSMOABIS_CFLAGS) \
-	$(LIBOSMOSCCP_CFLAGS) \
-	$(LIBOSMOMGCPCLIENT_CFLAGS) \
 	$(COVERAGE_CFLAGS) \
 	$(NULL)
 
 noinst_LIBRARIES = \
-	libcommon.a \
+	libgsupclient.a \
 	$(NULL)
 
-libcommon_a_SOURCES = \
+libgsupclient_a_SOURCES = \
 	gsup_client.c \
 	oap_client.c \
 	$(NULL)
@@ -32,7 +30,7 @@
 	gsup_test_client.c \
 	$(NULL)
 gsup_test_client_LDADD = \
-	libcommon.a \
+	libgsupclient.a \
 	$(LIBOSMOCORE_LIBS) \
 	$(LIBOSMOGSM_LIBS) \
 	$(LIBOSMOVTY_LIBS) \
diff --git a/src/libcommon/gsup_client.c b/src/libgsupclient/gsup_client.c
similarity index 100%
rename from src/libcommon/gsup_client.c
rename to src/libgsupclient/gsup_client.c
diff --git a/src/libcommon/gsup_test_client.c b/src/libgsupclient/gsup_test_client.c
similarity index 100%
rename from src/libcommon/gsup_test_client.c
rename to src/libgsupclient/gsup_test_client.c
diff --git a/src/libcommon/oap_client.c b/src/libgsupclient/oap_client.c
similarity index 100%
rename from src/libcommon/oap_client.c
rename to src/libgsupclient/oap_client.c
diff --git a/src/osmo-msc/Makefile.am b/src/osmo-msc/Makefile.am
index 1d8bfbd..1618fb5 100644
--- a/src/osmo-msc/Makefile.am
+++ b/src/osmo-msc/Makefile.am
@@ -35,7 +35,7 @@
 	$(top_builddir)/src/libmsc/libmsc.a \
 	$(top_builddir)/src/libvlr/libvlr.a \
 	$(top_builddir)/src/libcommon-cs/libcommon-cs.a \
-	$(top_builddir)/src/libcommon/libcommon.a \
+	$(top_builddir)/src/libgsupclient/libgsupclient.a \
 	$(LIBOSMOGSM_LIBS) \
 	$(LIBOSMOVTY_LIBS) \
 	$(LIBOSMOCORE_LIBS) \
diff --git a/src/utils/Makefile.am b/src/utils/Makefile.am
index ad3ed3f..fad522d 100644
--- a/src/utils/Makefile.am
+++ b/src/utils/Makefile.am
@@ -40,7 +40,6 @@
 	$(NULL)
 
 smpp_mirror_LDADD = \
-	$(top_builddir)/src/libcommon/libcommon.a \
 	$(LIBOSMOCORE_LIBS) \
 	$(LIBOSMOGSM_LIBS) \
 	$(LIBSMPP34_LIBS) \
diff --git a/tests/db/Makefile.am b/tests/db/Makefile.am
index 720e005..d6b1622 100644
--- a/tests/db/Makefile.am
+++ b/tests/db/Makefile.am
@@ -35,7 +35,6 @@
 	$(top_builddir)/src/libmsc/libmsc.a \
 	$(top_builddir)/src/libcommon-cs/libcommon-cs.a \
 	$(top_builddir)/src/libtrau/libtrau.a \
-	$(top_builddir)/src/libcommon/libcommon.a \
 	$(top_builddir)/tests/libiudummy/libiudummy.a \
 	$(LIBOSMOCORE_LIBS) \
 	$(LIBOSMOABIS_LIBS) \
diff --git a/tests/msc_vlr/Makefile.am b/tests/msc_vlr/Makefile.am
index 8194f22..ab2139b 100644
--- a/tests/msc_vlr/Makefile.am
+++ b/tests/msc_vlr/Makefile.am
@@ -40,7 +40,7 @@
 	$(top_builddir)/src/libmsc/libmsc.a \
 	$(top_builddir)/src/libcommon-cs/libcommon-cs.a \
 	$(top_builddir)/src/libvlr/libvlr.a \
-	$(top_builddir)/src/libcommon/libcommon.a \
+	$(top_builddir)/src/libgsupclient/libgsupclient.a \
 	$(LIBSMPP34_LIBS) \
 	$(LIBOSMOCORE_LIBS) \
 	$(LIBOSMOGSM_LIBS) \
diff --git a/tests/smpp/Makefile.am b/tests/smpp/Makefile.am
index 5082707..8d63119 100644
--- a/tests/smpp/Makefile.am
+++ b/tests/smpp/Makefile.am
@@ -34,7 +34,6 @@
 	$(NULL)
 
 smpp_test_LDADD = \
-	$(top_builddir)/src/libcommon/libcommon.a \
 	$(LIBOSMOCORE_LIBS) \
 	$(LIBOSMOGSM_LIBS) \
 	$(NULL)
diff --git a/tests/sms_queue/Makefile.am b/tests/sms_queue/Makefile.am
index 8c538b0..02bc3f2 100644
--- a/tests/sms_queue/Makefile.am
+++ b/tests/sms_queue/Makefile.am
@@ -32,7 +32,7 @@
 sms_queue_test_LDADD = \
 	$(top_builddir)/src/libmsc/libmsc.a \
 	$(top_builddir)/src/libvlr/libvlr.a \
-	$(top_builddir)/src/libcommon/libcommon.a \
+	$(top_builddir)/src/libgsupclient/libgsupclient.a \
 	$(top_builddir)/src/libcommon-cs/libcommon-cs.a \
 	$(LIBSMPP34_LIBS) \
 	$(LIBOSMOCORE_LIBS) \

-- 
To view, visit https://gerrit.osmocom.org/7453
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic71aa119c233b6a0ae169a5b2a53819903d2be82
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder

More information about the gerrit-log mailing list