libosmocore[master]: gsm_08_08: correct speech codec defaults

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 22 17:27:32 UTC 2018


Patch Set 1:

I'm not sure this is the right solution.  The structures we are using  (like struct gsm0808_speech_codec) are parsed , host data structures and not on-wire data structures.  So as a user, I would expect the bits to be in host byte order.  If I want to enable e.g. S11, then I expect to be able to do cfg |= (1 << 11).  The encoder then has to convert this to network byte order, and the decoder has to do the inverse.   Would you agree?

-- 
To view, visit https://gerrit.osmocom.org/7458
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c3a34d39a375d71c4128fd38f06629e8b98b100
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list