This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: cosmetic: remove needless fixme note. ...................................................................... cosmetic: remove needless fixme note. Change-Id: I4860412f8228756f7cd5669c4f6c7d845904e36b Related: OS#2823 --- M src/libbsc/bsc_subscr_conn_fsm.c 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libbsc/bsc_subscr_conn_fsm.c b/src/libbsc/bsc_subscr_conn_fsm.c index da9d46b..0d82564 100644 --- a/src/libbsc/bsc_subscr_conn_fsm.c +++ b/src/libbsc/bsc_subscr_conn_fsm.c @@ -316,14 +316,6 @@ /* FIXME: We need to check if current channel is sufficient. If * yes, do MODIFY. If not, do assignment (see commented lines below) */ - /* FIXME: At the moment, the FSM is constructed in an - * unfortunate way. In case of a voice channel assignment - * we first go through a couple of MGCP related states, - * then reach the state where the actual channel assignment - * happens and then again we perform some MGCP related - * actions and eventually end up in ST_ACTIVE again. This - * could be restructured */ - switch (conn->user_plane.chan_mode) { case GSM48_CMODE_SPEECH_V1: case GSM48_CMODE_SPEECH_EFR: -- To view, visit https://gerrit.osmocom.org/7423 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4860412f8228756f7cd5669c4f6c7d845904e36b Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder