[MERGED] osmo-bsc[master]: cosmetic: remove old, already commented-out code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Mar 22 12:55:49 UTC 2018


Harald Welte has submitted this change and it was merged.

Change subject: cosmetic: remove old, already commented-out code
......................................................................


cosmetic: remove old, already commented-out code

Change-Id: Ief994b840e3fe694b37330c46c3899746d810a39
Related: OS#2823
---
M src/osmo-bsc/osmo_bsc_api.c
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_api.c b/src/osmo-bsc/osmo_bsc_api.c
index 40c06dd..7a42f3c 100644
--- a/src/osmo-bsc/osmo_bsc_api.c
+++ b/src/osmo-bsc/osmo_bsc_api.c
@@ -259,7 +259,6 @@
 	}
 
 	/* allocate resource for a new connection */
-	//ret = bsc_create_new_connection(conn, msc, send_ping);
 	ret = osmo_bsc_sigtran_new_conn(conn, msc);
 
 	if (ret != BSC_CON_SUCCESS) {
@@ -283,7 +282,6 @@
 	resp = gsm0808_create_layer3_2(msg, cgi_for_msc(conn->sccp.msc, conn_get_bts(conn)), NULL);
 	if (!resp) {
 		LOGP(DMSC, LOGL_DEBUG, "Failed to create layer3 message.\n");
-		//osmo_bsc_sigtran_del_conn(conn);
 		return BSC_API_CONN_POL_REJECT;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/7427
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ief994b840e3fe694b37330c46c3899746d810a39
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list