This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/7431 BSSAP: Fix test_codec_pref() implementation for AMR In AMR-type cahnels, the gsm0808_speech_codec doesn't only include the codec (like EFR/FR/AMR) but also the specific codec configuration, i.e. the sub-set of AMR modes. Hence, we cannot convert from a channel type (just the codec) to the full gsm0808_speech_codec and then memcmp() that with the codec config received from the MSC. Rather, we must only compare the *type*. Change-Id: I0a3f362667a689135d5b62d151d491490dfd2976 Related: OS#3094 --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/31/7431/1 diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c index e793a14..04847b2 100644 --- a/src/osmo-bsc/osmo_bsc_bssap.c +++ b/src/osmo-bsc/osmo_bsc_bssap.c @@ -146,7 +146,7 @@ /* Try to find extrapolated speech codec data in * the speech codec list */ for (i = 0; i < scl->len; i++) { - if (memcmp(&sc, &scl->codec[i], sizeof(sc)) == 0) + if (sc.type == scl->codec[i].type) return true; } -- To view, visit https://gerrit.osmocom.org/7431 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a3f362667a689135d5b62d151d491490dfd2976 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org>