This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/7422 cosmetic: fix argument order of forward_dtap() The order of the arguments for forward_dtap() differs from submit_dtap() and sigtran_send() - bring arguments into a uniform order for all three functions Change-Id: Ida77c82e600f99d690ffa1850450925359e33ae8 Related: OS#2823 --- M src/libbsc/bsc_subscr_conn_fsm.c 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/22/7422/1 diff --git a/src/libbsc/bsc_subscr_conn_fsm.c b/src/libbsc/bsc_subscr_conn_fsm.c index cdd85be..da9d46b 100644 --- a/src/libbsc/bsc_subscr_conn_fsm.c +++ b/src/libbsc/bsc_subscr_conn_fsm.c @@ -196,8 +196,7 @@ } /* forward MO DTAP from RSL side to BSSAP side */ -/* FIXME: move fi parameter to the beginning */ -static void forward_dtap(struct msgb *msg, struct gsm_subscriber_connection *conn, struct osmo_fsm_inst *fi) +static void forward_dtap(struct gsm_subscriber_connection *conn, struct msgb *msg, struct osmo_fsm_inst *fi) { struct msgb *resp = NULL; @@ -397,7 +396,7 @@ /* FIXME: reject any handover requests with HO FAIL until implemented */ break; case GSCON_EV_MO_DTAP: - forward_dtap((struct msgb *)data, conn, fi); + forward_dtap(conn, (struct msgb *)data, fi); break; case GSCON_EV_MT_DTAP: submit_dtap(conn, (struct msgb *)data, fi); @@ -457,7 +456,7 @@ osmo_fsm_inst_state_chg(fi, ST_WAIT_ASS_CMPL, GSM0808_T10_VALUE, GSM0808_T10_TIMER_NR); break; case GSCON_EV_MO_DTAP: - forward_dtap((struct msgb *)data, conn, fi); + forward_dtap(conn, (struct msgb *)data, fi); break; case GSCON_EV_MT_DTAP: submit_dtap(conn, (struct msgb *)data, fi); @@ -532,7 +531,7 @@ osmo_fsm_inst_state_chg(fi, ST_ACTIVE, 0, 0); break; case GSCON_EV_MO_DTAP: - forward_dtap((struct msgb *)data, conn, fi); + forward_dtap(conn, (struct msgb *)data, fi); break; case GSCON_EV_MT_DTAP: submit_dtap(conn, (struct msgb *)data, fi); @@ -583,7 +582,7 @@ break; case GSCON_EV_MO_DTAP: - forward_dtap((struct msgb *)data, conn, fi); + forward_dtap(conn, (struct msgb *)data, fi); break; case GSCON_EV_MT_DTAP: submit_dtap(conn, (struct msgb *)data, fi); @@ -621,7 +620,7 @@ break; case GSCON_EV_MO_DTAP: - forward_dtap((struct msgb *)data, conn, fi); + forward_dtap(conn, (struct msgb *)data, fi); break; case GSCON_EV_MT_DTAP: submit_dtap(conn, (struct msgb *)data, fi); @@ -654,7 +653,7 @@ break; /* FIXME: Do we need to handle DTAP traffic in this state? Maybe yes? Needs to be checked. */ case GSCON_EV_MO_DTAP: - forward_dtap((struct msgb *)data, conn, fi); + forward_dtap(conn, (struct msgb *)data, fi); break; case GSCON_EV_MT_DTAP: submit_dtap(conn, (struct msgb *)data, fi); @@ -748,7 +747,7 @@ osmo_fsm_inst_state_chg(fi, ST_ACTIVE, 0, 0); break; case GSCON_EV_MO_DTAP: - forward_dtap((struct msgb *)data, conn, fi); + forward_dtap(conn, (struct msgb *)data, fi); break; case GSCON_EV_MT_DTAP: submit_dtap(conn, (struct msgb *)data, fi); -- To view, visit https://gerrit.osmocom.org/7422 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida77c82e600f99d690ffa1850450925359e33ae8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de>