[PATCH] osmo-ttcn3-hacks[master]: don't use setverdict(inconc) anymore. Use 'fail' at all times

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Mar 21 10:28:25 UTC 2018


Review at  https://gerrit.osmocom.org/7409

don't use setverdict(inconc) anymore.  Use 'fail' at all times

The problem is that Junit-XML doesn't have a mapping for inconclusive
results, and hence they show up as 'passed'.

By introducing this change, we make sure all tests that don't pass
show up as failed.

Change-Id: Iddd13d0055c91f9bd304ce9833fba0485abf4c4e
---
M bsc-nat/MSC_ConnectionHandler.ttcn
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
M msc/MSC_Tests.ttcn
4 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/7409/1

diff --git a/bsc-nat/MSC_ConnectionHandler.ttcn b/bsc-nat/MSC_ConnectionHandler.ttcn
index 0a06759..102869c 100644
--- a/bsc-nat/MSC_ConnectionHandler.ttcn
+++ b/bsc-nat/MSC_ConnectionHandler.ttcn
@@ -146,7 +146,7 @@
 		/* Guard timer has expired, close connection */
 		[] T.timeout {
 			BSSAP.send(BSSAP_Conn_Prim:MSC_CONN_PRIM_DISC_REQ);
-			setverdict(inconc);
+			setverdict(fail, "Timeout of guard timer");
 			self.stop;
 			}
 
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index aff6336..ea90f06 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1674,7 +1674,7 @@
 		setverdict(pass);
 		}
 	[] BSSAP.receive { setverdict(fail, "unexpected BSSAP"); }
-	[] T.timeout { setverdict(inconc); }
+	[] T.timeout { setverdict(fail, "Timeout waiting for RR STATUS"); }
 	}
 }
 testcase TC_err_84_unknown_msg() runs on test_CT {
diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 62c2a71..7c5a6d7 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -682,7 +682,7 @@
 		setverdict(fail, "Received non-matching ASSIGNMENT FAIL");
 		}
 	[] T.timeout {
-		setverdict(inconc, "Timeout waiting for ASSIGNMENT COMPLETE");
+		setverdict(fail, "Timeout waiting for ASSIGNMENT COMPLETE");
 		}
 	}
 	log("g_media ", g_media);
diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 5ae5d60..84f33b7 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -161,7 +161,7 @@
 	alt {
 		[] GSUP_IPA_EVENT.receive(t_ASP_IPA_EVT_UD(ASP_IPA_EVENT_UP)) { }
 		[] T.timeout {
-			setverdict(inconc, "No connection to GSUP Port");
+			setverdict(fail, "No connection to GSUP Port");
 			self.stop
 		}
 	}
@@ -1511,7 +1511,7 @@
 		self.stop;
 		}
 	[] BSSAP.receive {
-		setverdict(inconc, "Unknown/unexpected BSSAP received");
+		setverdict(fail, "Unknown/unexpected BSSAP received");
 		self.stop;
 		}
 	}
@@ -1578,7 +1578,7 @@
 		self.stop;
 		}
 	[] BSSAP.receive {
-		setverdict(inconc, "Unknown/unexpected BSSAP received");
+		setverdict(fail, "Unknown/unexpected BSSAP received");
 		self.stop;
 		}
 	}

-- 
To view, visit https://gerrit.osmocom.org/7409
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddd13d0055c91f9bd304ce9833fba0485abf4c4e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list