[PATCH] osmo-ttcn3-hacks[master]: MSC_Tests: Fix to use 2-digit MNC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Mar 18 16:09:15 UTC 2018


Review at  https://gerrit.osmocom.org/7371

MSC_Tests: Fix to use 2-digit MNC

Until recently, OsmoMSC didn't distinguish 2-digit from 3-digit MNC,
and the config file states '42' as MNC while the tester used '042' in
several locations.  This causes almost all MSC_Tests fail with recent
osmo-msc.

Let's fix the tests to use '42', as they should always have.

Change-Id: Id02bfd74127cf5551923912934240035106a8a4e
---
M msc/MSC_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/7371/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index e154911..10f772e 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -378,7 +378,7 @@
 	var BSC_ConnHdlrPars pars := {
 		sccp_addr_own := g_bssap.sccp_addr_own,
 		sccp_addr_peer := g_bssap.sccp_addr_peer,
-		cell_id := valueof(ts_CellId_CGI('262'H, '042'H, 23, 42)),
+		cell_id := valueof(ts_CellId_CGI('262'H, '42'H, 23, 42)),
 		imei := f_gen_imei(imsi_suffix),
 		imsi := f_gen_imsi(imsi_suffix),
 		msisdn := f_gen_msisdn(imsi_suffix),
@@ -521,7 +521,7 @@
 	f_init_handler(pars);
 
 	var MobileIdentityLV mi := valueof(ts_MI_IMSI_LV(g_pars.imsi));
-	var BSSMAP_IE_CellIdentifier cell_id := valueof(ts_CellId_CGI('262'H, '042'H, 23, 42));
+	var BSSMAP_IE_CellIdentifier cell_id := valueof(ts_CellId_CGI('262'H, '42'H, 23, 42));
 	var PDU_ML3_MS_NW l3_info := valueof(ts_CM_SERV_REQ(CM_TYPE_MO_CALL, mi));
 
 	f_create_gsup_expect(hex2str(g_pars.imsi));

-- 
To view, visit https://gerrit.osmocom.org/7371
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id02bfd74127cf5551923912934240035106a8a4e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list