osmo-msc[master]: libmsc: Close connection after sending a service reject

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Mar 16 09:02:03 UTC 2018


Patch Set 2: -Code-Review

As we can have multiple CM connections over the same RR connection, I think that CM service establishment should be tied to our "transaction" logic to get things right.

Every tuple of (proto_disc, trans_id) has separate CM SERVICE REQ/RESP/REJ.  So we should probably create a trans structure every time we receive one of those [on a separate tuple], and simply drop the trans when we send a CM SERV REJ.  The trans.c code should then discover that (unless other trans are active) the RR connection can be released.

-- 
To view, visit https://gerrit.osmocom.org/6503
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfa39fdbe5bb764f8ea2bbf8c5442e15e01cadbb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list