This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 5: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py File src/osmo_gsm_tester/bts_osmo.py: Line 80: def ready_for_pcu(self): > This change improves legibility of the code by correctly sorting the file f I still disagree and believe non-public member functions should have leading underscores as convention in python, and all other functions are available and also free to be called from tests, why not. But whatever, I'll let you impose your style on the code base all right. -- To view, visit https://gerrit.osmocom.org/7159 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8978854404897ae5de7e3100d55d86c7a5c1df1 Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-HasComments: Yes