This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged.
Change subject: Transceiver.cpp: use a define for the MAX_PACKET_LENGTH
......................................................................
Transceiver.cpp: use a define for the MAX_PACKET_LENGTH
No need to keep this value on stack.
Change-Id: If9ffb03b9e7b642f45732ba5938977bca271f1c7
---
M Transceiver52M/Transceiver.cpp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Pau Espin Pedrol: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index 8ebd9ed..7dc4c1c 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -657,10 +657,10 @@
}
+#define MAX_PACKET_LENGTH 100
+
void Transceiver::driveControl(size_t chan)
{
- int MAX_PACKET_LENGTH = 100;
-
// check control socket
char buffer[MAX_PACKET_LENGTH];
int msgLen = -1;
--
To view, visit https://gerrit.osmocom.org/7170
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9ffb03b9e7b642f45732ba5938977bca271f1c7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>