This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/7288 fix a cell identifier parsing bug in libosmocore Global and LAI+LAC cell IDs were being misparsed due to an off-by-one. This code was incorrectly converted from osmo-bsc, where an additional offset of one byte was needed to skip the cell identifier field. In libosmocore, these parsing routines receive a buffer pointer which is already positioned at the start of the cell identifier field. Change-Id: I7f3e8ace26176e9cbfe2542961d2a95662aa4d97 Related: OS#2847 --- M src/gsm/gsm0808_utils.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/7288/1 diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c index a07ef0e..e12a968 100644 --- a/src/gsm/gsm0808_utils.c +++ b/src/gsm/gsm0808_utils.c @@ -703,7 +703,7 @@ if (i >= GSM0808_CELL_ID_LIST2_MAXLEN) return -ENOSPC; id = &id_list[i]; - lai_offset = 1 + i * elemlen; + lai_offset = i * elemlen; if (decode_lai(&data[lai_offset], &id->lai.plmn.mcc, &id->lai.plmn.mnc, &id->lai.lac) != 0) return -EINVAL; ci_be = (uint16_t *)(&data[lai_offset + sizeof(struct gsm48_loc_area_id)]); @@ -775,7 +775,7 @@ if (i >= GSM0808_CELL_ID_LIST2_MAXLEN) return -ENOSPC; id = &id_list[i]; - if (decode_lai(&data[1 + i * elemlen], &id->plmn.mcc, &id->plmn.mnc, &id->lac) != 0) + if (decode_lai(&data[i * elemlen], &id->plmn.mcc, &id->plmn.mnc, &id->lac) != 0) return -EINVAL; *consumed += elemlen; remain -= elemlen; -- To view, visit https://gerrit.osmocom.org/7288 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7f3e8ace26176e9cbfe2542961d2a95662aa4d97 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>