[PATCH] osmo-msc[master]: Track libosmocore API change in osmo-msc.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Mon Mar 12 17:41:28 UTC 2018


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/6518

to look at the new patch set (#2).

Track libosmocore API change in osmo-msc.

struct gsm0808_cell_id_list in libosmocore is deprecated by
https://gerrit.osmocom.org/#/c/6509/

This updates the only API user I am aware of.

Change-Id: I67377270cf3b081ac5dc9cd7b4dc28f74143753a
Depends: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
---
M src/libmsc/a_iface.c
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/18/6518/2

diff --git a/src/libmsc/a_iface.c b/src/libmsc/a_iface.c
index 79b1b4c..fa8c5c3 100644
--- a/src/libmsc/a_iface.c
+++ b/src/libmsc/a_iface.c
@@ -194,7 +194,7 @@
 int a_iface_tx_paging(const char *imsi, uint32_t tmsi, uint16_t lac)
 {
 	struct bsc_context *bsc_ctx;
-	struct gsm0808_cell_id_list cil;
+	struct gsm0808_cell_id_list2 cil;
 	struct msgb *msg;
 	int page_count = 0;
 	struct osmo_ss7_instance *ss7;
@@ -202,7 +202,7 @@
 	OSMO_ASSERT(imsi);
 
 	cil.id_discr = CELL_IDENT_LAC;
-	cil.id_list_lac[0] = lac;
+	cil.id_list[0].lac = lac;
 	cil.id_list_len = 1;
 
 	ss7 = osmo_ss7_instance_find(gsm_network->a.cs7_instance);
@@ -215,7 +215,7 @@
 			     "Tx BSSMAP paging message from MSC %s to BSC %s (imsi=%s, tmsi=0x%08x, lac=%u)\n",
 			     osmo_sccp_addr_name(ss7, &bsc_ctx->msc_addr),
 			     osmo_sccp_addr_name(ss7, &bsc_ctx->bsc_addr), imsi, tmsi, lac);
-			msg = gsm0808_create_paging(imsi, &tmsi, &cil, NULL);
+			msg = gsm0808_create_paging2(imsi, &tmsi, &cil, NULL);
 			osmo_sccp_tx_unitdata_msg(bsc_ctx->sccp_user,
 						  &bsc_ctx->msc_addr, &bsc_ctx->bsc_addr, msg);
 			page_count++;

-- 
To view, visit https://gerrit.osmocom.org/6518
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I67377270cf3b081ac5dc9cd7b4dc28f74143753a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list