osmo-trx[master]: Transceiver.cpp: use pointer arithmetics for CMD parsing

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Mar 9 14:40:11 UTC 2018


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/7172/1/Transceiver52M/Transceiver.cpp
File Transceiver52M/Transceiver.cpp:

Line 672:   size_t cmd_len = strlen(cmd);
> Thanks!
You can add a macro:
#define MATCH_CMD(buf, cmd, params) match_cmd(buf, cmd, sizeof(cmd) - 1, params)

You can even stringify cmd in the macro and pass MATCH_CMD(buf, POWEROFF, &params).


-- 
To view, visit https://gerrit.osmocom.org/7172
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I226ca0771e63228cf5e04ef9766057d4107fdd11
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list