This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/6917/5/src/osmo_ms_driver/starter.py File src/osmo_ms_driver/starter.py: Line 107: def start_mobile(self, loop): > Can now be called start(), as it's already in the mobile class. You are the maintainer but I wouldn't do it: * start is too generic. Good luck finding the right method with git grep. ;) * As you pointed out the virtphy and mob are two very different things (and launched at two different phases of the test process) and we don't benefit from the "start" polymorphism. By definition they are not compatible/the same (in terms of duck typing) and by not having the same methods it will fail with an exception.. If you want to pick a common name I would pick: launch_process. It describes what it is done (launch a process), one can git grep for it, and most likely it will stay the same (we continue to launch processes). -- To view, visit https://gerrit.osmocom.org/6917 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c6d742842d7f3e0a1858436ef3f8634d8c0582d Gerrit-PatchSet: 5 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes