This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/7059/1/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: Line 3683: return GSM48_REJECT_PROTOCOL_ERROR; remember, this is the cause value as sent back to the MS. What has the MS done wrong in terms of a "protocol error" in the messages it has sent in order to provoke this? I think these cases are about some problem between MSC and VLR? If yes, this cause value is not applicable. Section 8 of TS 24.008 unfortunately is not very precise when it comes to all possible error cases/causes. However, Annex G of the same spec explicitly states that "protocol error" relates to an invalid message (sent by the MS in this situation). Without comprehensive review I would argue that 17 (netwokr failure) is more applicable both here and a few lines below. -- To view, visit https://gerrit.osmocom.org/7059 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4db77fea1a4bcd161218582126a5d83ca171f7cb Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes