This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: fake_trx: Increase TOA256 value ranges ...................................................................... fake_trx: Increase TOA256 value ranges In theory, the maximum TA value is 63 symbols, i.e. 63*256 in this context. However, our test cases want to test the BTS behavior is correct if ever a larger timing offset is reported from TRX to the BTS, to ensure it is rejected in the BTS. Let's hence increase the values to rather large min/max limits. We could also remove them completely. Change-Id: I691d081256e8c6d18ef2836299ed8f7d502da3ee --- M src/target/fake_trx/data_msg.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Vadim Yanitskiy: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved; Verified diff --git a/src/target/fake_trx/data_msg.py b/src/target/fake_trx/data_msg.py index 5f93187..a48eff7 100644 --- a/src/target/fake_trx/data_msg.py +++ b/src/target/fake_trx/data_msg.py @@ -304,8 +304,8 @@ RSSI_MAX = -50 # TODO: verify this range - TOA256_MIN = -256 * 10 - TOA256_MAX = 256 * 10 + TOA256_MIN = -256 * 200 + TOA256_MAX = 256 * 200 # Specific message fields rssi = None -- To view, visit https://gerrit.osmocom.org/7014 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I691d081256e8c6d18ef2836299ed8f7d502da3ee Gerrit-PatchSet: 4 Gerrit-Project: osmocom-bb Gerrit-Branch: fixeria/trx Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>