Change in osmo-ttcn3-hacks[master]: MGCP_Test: do not use constant IP addresses

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jun 29 17:39:59 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9787 )

Change subject: MGCP_Test: do not use constant IP addresses
......................................................................

MGCP_Test: do not use constant IP addresses

The RTP stream tests TC_two_crcx_and_unsolicited_rtp and
TC_two_crcx_and_one_mdcx_rtp_ho, which were introduced recently
with Change-Id I556a6efff0e74aab897bd8165200eec36e46629f, use
hardcoded ip addresses (127.0.0.1) to establish the RTP streams
that are used to test how the MGW reacts on unsolicited packets.
This works fine when everything runs on local host but on docker
it failes since the containers there have different ip-addresses.

- replace hardcoded IP-Addresses with modulepar variable in
  TC_two_crcx_and_unsolicited_rtp and TC_two_crcx_and_one_mdcx_rtp_ho

Change-Id: I5af5186f173c2b8564e8034249c82245acdd09f6
Related: OS#2703
---
M mgw/MGCP_Test.ttcn
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index 8746c38..d816a71 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -1164,8 +1164,8 @@
 		f_sleep(0.5);
 
 		/* Start inserting unsolicited RTP packets */
-		f_rtpem_bind(RTPEM[2], "127.0.0.1", unsolicited_port);
-		f_rtpem_connect(RTPEM[2], "127.0.0.1", flow[0].mgw.portnr);
+		f_rtpem_bind(RTPEM[2], mp_local_ip, unsolicited_port);
+		f_rtpem_connect(RTPEM[2], mp_remote_ip, flow[0].mgw.portnr);
 		f_rtpem_mode(RTPEM[2], RTPEM_MODE_TXONLY);
 
 		f_sleep(0.5);
@@ -1219,8 +1219,8 @@
 		 * transmitting for a while. We simulate this by injecting
 		 * some unsolicited packets on the behalf of the old source,
 		 * (old remote port) */
-		f_rtpem_bind(RTPEM[2], "127.0.0.1", port_old);
-		f_rtpem_connect(RTPEM[2], "127.0.0.1", flow[0].mgw.portnr);
+		f_rtpem_bind(RTPEM[2], mp_local_ip, port_old);
+		f_rtpem_connect(RTPEM[2], mp_remote_ip, flow[0].mgw.portnr);
 		f_rtpem_mode(RTPEM[2], RTPEM_MODE_TXONLY);
 		f_sleep(1.0);
 		f_rtpem_mode(RTPEM[2], RTPEM_MODE_NONE);

-- 
To view, visit https://gerrit.osmocom.org/9787
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5af5186f173c2b8564e8034249c82245acdd09f6
Gerrit-Change-Number: 9787
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180629/509db0ac/attachment.htm>


More information about the gerrit-log mailing list