Change in osmo-bsc[master]: bsc_vty: Write access list entries when storing bsc config

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9762 )

Change subject: bsc_vty: Write access list entries when storing bsc config
......................................................................

bsc_vty: Write access list entries when storing bsc config

Change-Id: Ice8ce203a52b918e1eddb56ea437d082efd634bc
---
M include/osmocom/bsc/bsc_msg_filter.h
M src/libfilter/bsc_msg_vty.c
M src/osmo-bsc/osmo_bsc_vty.c
3 files changed, 12 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/bsc/bsc_msg_filter.h b/include/osmocom/bsc/bsc_msg_filter.h
index c9d86f4..2740905 100644
--- a/include/osmocom/bsc/bsc_msg_filter.h
+++ b/include/osmocom/bsc/bsc_msg_filter.h
@@ -100,4 +100,4 @@
 int bsc_msg_acc_lst_check_allow(struct bsc_msg_acc_lst *lst, const char *imsi);
 
 void bsc_msg_lst_vty_init(void *ctx, struct llist_head *lst, int node);
-void bsc_msg_acc_lst_write(struct vty *vty, struct bsc_msg_acc_lst *lst);
+void bsc_msg_acc_lst_write(struct vty *vty);
diff --git a/src/libfilter/bsc_msg_vty.c b/src/libfilter/bsc_msg_vty.c
index 52e0da5..bcee37e 100644
--- a/src/libfilter/bsc_msg_vty.c
+++ b/src/libfilter/bsc_msg_vty.c
@@ -111,7 +111,7 @@
 	return CMD_SUCCESS;
 }
 
-void bsc_msg_acc_lst_write(struct vty *vty, struct bsc_msg_acc_lst *lst)
+static void bsc_msg_acc_lst_write_one(struct vty *vty, struct bsc_msg_acc_lst *lst)
 {
 	struct bsc_msg_acc_lst_entry *entry;
 
@@ -127,6 +127,14 @@
 	}
 }
 
+void bsc_msg_acc_lst_write(struct vty *vty)
+{
+	struct bsc_msg_acc_lst *lst;
+	llist_for_each_entry(lst, _acc_lst, list) {
+		bsc_msg_acc_lst_write_one(vty, lst);
+	}
+}
+
 void bsc_msg_lst_vty_init(void *ctx, struct llist_head *lst, int node)
 {
 	_ctx = ctx;
diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c
index 3ed2238..f6f1b8a 100644
--- a/src/osmo-bsc/osmo_bsc_vty.c
+++ b/src/osmo-bsc/osmo_bsc_vty.c
@@ -222,6 +222,8 @@
 	if (bsc->acc_lst_name)
 		vty_out(vty, " access-list-name %s%s", bsc->acc_lst_name, VTY_NEWLINE);
 
+	bsc_msg_acc_lst_write(vty);
+
 	return CMD_SUCCESS;
 }
 

-- 
To view, visit https://gerrit.osmocom.org/9762
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice8ce203a52b918e1eddb56ea437d082efd634bc
Gerrit-Change-Number: 9762
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180628/ca73f76c/attachment.htm>