This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9656 ) Change subject: libvlr/vlr.c: introduce the generic GSUP message router ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/9656/2/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/9656/2/src/libvlr/vlr.c@969 PS2, Line 969: static int vlr_route_gsup_msg I would move that entire function out of libvlr. Just have the MSC provide this function as a function pointer during vlr_start() or the like. This way the libvlr code stays clean. -- To view, visit https://gerrit.osmocom.org/9656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8146ce5788c8f249dcaa39d61bd0388574bf892 Gerrit-Change-Number: 9656 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 25 Jun 2018 10:38:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180625/d2824f5d/attachment.htm>