Change in libosmocore[master]: gprs_bssgp: extend log output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Jun 21 12:20:27 UTC 2018


dexter has uploaded this change for review. ( https://gerrit.osmocom.org/9702


Change subject: gprs_bssgp: extend log output
......................................................................

gprs_bssgp: extend log output

When uplink unit data is received, then the debug log shows the TLLI
only, however it would also be interesting to know the exact length of the
data as well as the contents of the LLCPU that is received

- Display TLLI and LLCPDU-length on log level info
- Display TLLI, LLCPDU-length and a hexdump of the LLCPDU on log
  level debug

Change-Id: I2980174c899b63717efe218ff5ec8d314c0d6da4
Patch-by: Octasic inc.
Related: SYS#4257
---
M src/gb/gprs_bssgp.c
1 file changed, 9 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/9702/1

diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c
index d5d4ea8..fb1862b 100644
--- a/src/gb/gprs_bssgp.c
+++ b/src/gb/gprs_bssgp.c
@@ -389,7 +389,15 @@
 	/* extract TLLI and parse TLV IEs */
 	msgb_tlli(msg) = osmo_ntohl(budh->tlli);
 
-	DEBUGP(DBSSGP, "BSSGP TLLI=0x%08x Rx UPLINK-UNITDATA\n", msgb_tlli(msg));
+	LOGP(DBSSGP, LOGL_INFO,
+	     "BSSGP TLLI=0x%08x Rx PLINK-UNITDATA, LLC-PDU LEN[%u]\n",
+	     msgb_tlli(msg), TLVP_LEN(tp, BSSGP_IE_LLC_PDU));
+
+	LOGP(DBSSGP, LOGL_DEBUG, "TLLI=0x%08x, LLC-PDU LEN[%u], DATA[%s]\n",
+	     msgb_tlli(msg),
+	     TLVP_LEN(tp, BSSGP_IE_LLC_PDU),
+	     osmo_hexdump((uint8_t *) TLVP_VAL(tp, BSSGP_IE_LLC_PDU),
+			  TLVP_LEN(tp, BSSGP_IE_LLC_PDU)));
 
 	/* Cell ID and LLC_PDU are the only mandatory IE */
 	if (!TLVP_PRESENT(tp, BSSGP_IE_CELL_ID) ||

-- 
To view, visit https://gerrit.osmocom.org/9702
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2980174c899b63717efe218ff5ec8d314c0d6da4
Gerrit-Change-Number: 9702
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180621/2a4333b3/attachment.htm>


More information about the gerrit-log mailing list