Change in osmo-ttcn3-hacks[master]: bsc: handover: actually send Handover Detect

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/9673


Change subject: bsc: handover: actually send Handover Detect
......................................................................

bsc: handover: actually send Handover Detect

Until now, the test went from RR Handover Command directly to RR Handover
Complete, and osmo-bsc didn't mind it. However, the normal handover procedure
requires an RSL Handover Detect to be sent in-between those. Send that.

Change-Id: I6e54edcc3a99e116d852eca8e48c7a5bc685e832
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/9673/1

diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index 0846762..9661ce3 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -858,6 +858,14 @@
 	RslChannelNr old_chan_nr
 };
 
+template (value) RSL_Message ts_RSL_HANDO_DET(template (value) RslChannelNr chan_nr) := {
+	msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false),
+	msg_type := RSL_MT_HANDO_DET,
+	ies := {
+		t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr})
+	}
+}
+
 altstep as_handover(inout HandoverState st) runs on MSC_ConnHdlr {
 	var RSL_Message rsl;
 	[not st.rr_ho_cmpl_seen] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr)) -> value rsl {
@@ -877,6 +885,10 @@
 			 * before performing a hand-over */
 			f_rslem_resume(RSL1_PROC);
 
+			/* send handover detect */
+			RSL1.send(ts_RSL_HANDO_DET(new_chan_nr));
+			f_sleep(0.3);
+
 			/* send handover complete over the new channel */
 			var PDU_ML3_MS_NW l3_tx := valueof(ts_RRM_HandoverComplete('00'O));
 			RSL1.send(ts_RSL_DATA_IND(new_chan_nr, valueof(ts_RslLinkID_DCCH(0)),

-- 
To view, visit https://gerrit.osmocom.org/9673
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e54edcc3a99e116d852eca8e48c7a5bc685e832
Gerrit-Change-Number: 9673
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180618/3220b028/attachment.htm>