Change in osmo-trx[master]: lms: Makefile.am: Reorder params to fix link issue

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 13 21:45:37 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9612 )

Change subject: lms: Makefile.am: Reorder params to fix link issue
......................................................................

lms: Makefile.am: Reorder params to fix link issue

It seems the order in which static code and -lfoo is passed to the
linker matters.

This commit is a lms specific follow-up of commit
2a8183bdf0dfd5c5a59c3933fb932e827ddf811c.

Change-Id: I59c20d268ecac4c22689124165c47295bd9176d4
---
M Transceiver52M/Makefile.am
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am
index a2163bf..28c47ab 100644
--- a/Transceiver52M/Makefile.am
+++ b/Transceiver52M/Makefile.am
@@ -104,8 +104,8 @@
 bin_PROGRAMS += osmo-trx-lms
 osmo_trx_lms_SOURCES = osmo-trx.cpp
 osmo_trx_lms_LDADD = \
+	$(builddir)/device/lms/libdevice.la \
 	$(COMMON_LDADD) \
-	$(LMS_LIBS) \
-	$(builddir)/device/lms/libdevice.la
+	$(LMS_LIBS)
 osmo_trx_lms_CPPFLAGS  = $(AM_CPPFLAGS) $(LMS_CFLAGS)
 endif

-- 
To view, visit https://gerrit.osmocom.org/9612
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I59c20d268ecac4c22689124165c47295bd9176d4
Gerrit-Change-Number: 9612
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180613/1929d356/attachment.htm>


More information about the gerrit-log mailing list