Change in osmocom-bb[master]: osmocon: Set compiler attr to unused variables

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 13 11:51:44 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9565 )

Change subject: osmocon: Set compiler attr to unused variables
......................................................................

osmocon: Set compiler attr to unused variables

Variables are not removed as they document the commands of the
propietary romloader.

Let's mark them as unused to avoid compilation warnings.

Change-Id: If4c6814ada85956975e687eb43dcfd4ad70b8b94
---
M src/host/osmocon/osmocon.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c
index 2e822e8..131eab7 100644
--- a/src/host/osmocon/osmocon.c
+++ b/src/host/osmocon/osmocon.c
@@ -210,13 +210,13 @@
 
 /* Calypso romloader specific */
 static const uint8_t romload_ident_cmd[] =	{ 0x3c, 0x69 };	/* <i */
-static const uint8_t romload_abort_cmd[] =	{ 0x3c, 0x61 };	/* <a */
+static const uint8_t __attribute__((__unused__)) romload_abort_cmd[] =	{ 0x3c, 0x61 };	/* <a */
 static const uint8_t romload_write_cmd[] =	{ 0x3c, 0x77 };	/* <w */
 static const uint8_t romload_checksum_cmd[] =	{ 0x3c, 0x63 };	/* <c */
 static const uint8_t romload_branch_cmd[] =	{ 0x3c, 0x62 };	/* <b */
 static const uint8_t romload_ident_ack[] =	{ 0x3e, 0x69 };	/* >i */
 static const uint8_t romload_param_ack[] =	{ 0x3e, 0x70 };	/* >p */
-static const uint8_t romload_param_nack[] =	{ 0x3e, 0x50 };	/* >P */
+static const uint8_t __attribute__((__unused__)) romload_param_nack[] =	{ 0x3e, 0x50 };	/* >P */
 static const uint8_t romload_block_ack[] =	{ 0x3e, 0x77 };	/* >w */
 static const uint8_t romload_block_nack[] =	{ 0x3e, 0x57 };	/* >W */
 static const uint8_t romload_checksum_ack[] =	{ 0x3e, 0x63 };	/* >c */

-- 
To view, visit https://gerrit.osmocom.org/9565
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If4c6814ada85956975e687eb43dcfd4ad70b8b94
Gerrit-Change-Number: 9565
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180613/df036b21/attachment.htm>


More information about the gerrit-log mailing list