Change in openbsc[master]: chan_alloc: Fix crash when failing to allocate channel

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Jun 13 11:10:39 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9596 )

Change subject: chan_alloc: Fix crash when failing to allocate channel
......................................................................

chan_alloc: Fix crash when failing to allocate channel

Fix a really silly bug I introduced recently (same commit in
osmo-bsc.git doesn't contain the issue).

Fixes: d05d05b2773a1dc96a51104034942d504f2b1166
Related: SYS#4254
Change-Id: I7bac2ce001d4a6dcea2a896af30edf84942b68de
---
M openbsc/src/libbsc/chan_alloc.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/libbsc/chan_alloc.c b/openbsc/src/libbsc/chan_alloc.c
index 97c1902..606dfa7 100644
--- a/openbsc/src/libbsc/chan_alloc.c
+++ b/openbsc/src/libbsc/chan_alloc.c
@@ -363,7 +363,7 @@
 		struct challoc_signal_data sig;
 
 		LOGP(DRLL, LOGL_ERROR, "(bts=%d) Failed to allocate %s channel\n",
-		     gsm_ts_and_pchan_name(bts->nr), gsm_lchant_name(type));
+		     bts->nr, gsm_lchant_name(type));
 
 		sig.bts = bts;
 		sig.type = type;

-- 
To view, visit https://gerrit.osmocom.org/9596
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bac2ce001d4a6dcea2a896af30edf84942b68de
Gerrit-Change-Number: 9596
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180613/f7262b03/attachment.htm>


More information about the gerrit-log mailing list