Change in libosmocore[master]: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Jun 11 12:06:16 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9528 )

Change subject: gsm/gsm0480.c: introduce gsm0480_extract_ie_by_tag()
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/9528/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9528/2//COMMIT_MSG@10
PS2, Line 10: conversation
conversion


https://gerrit.osmocom.org/#/c/9528/2/src/gsm/gsm0480.c
File src/gsm/gsm0480.c:

https://gerrit.osmocom.org/#/c/9528/2/src/gsm/gsm0480.c@218
PS2, Line 218: int gsm0480_extract_ie_by_tag(const struct gsm48_hdr *hdr, uint16_t msg_len,
I know the old code may not always have docxygen API documentation, but we should always icnlude it for any new public APi we introduce. Thanks!



-- 
To view, visit https://gerrit.osmocom.org/9528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3989d061903352473305f80712f1a1560d05df3d
Gerrit-Change-Number: 9528
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 11 Jun 2018 12:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180611/eb5da494/attachment.htm>


More information about the gerrit-log mailing list