Change in osmo-bsc[master]: dissolve libbsc: move all to src/osmo-bsc, link .o files

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jun 7 17:09:17 UTC 2018


Hello Harald Welte, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/9481

to look at the new patch set (#4).

Change subject: dissolve libbsc: move all to src/osmo-bsc, link .o files
......................................................................

dissolve libbsc: move all to src/osmo-bsc, link .o files

Move all of libbsc/ into osmo-bsc/, and separate/move some implementations to
allow linking from utils/* and ipaccess/* without pulling in unccessary
dependencies.

Some utilities use gsm_network and gsm_bts structs, which already include data
structures for fairly advanced uses. Move initialization that only osmo-bsc
needs into new bsc_network_init() and bsc_bts_alloc_register() functions, so
that the leaner tools can use the old gsm_* versions without the need to link
everything (e.g. handover and lchan alloc code).

In some instances, there need to be stubs if to cut off linking "just before
the RSL level" and prevent dependencies from creeping in.
- abis_rsl_rcvmsg(): the only program currently interpreting RSL messages is
  osmo-bsc, the utils are merely concerned with OML, if at all.
- paging_flush_bts(): ip.access nanobts models call this when the RSL link is
  dropped. Only osmo-bsc actually needs to do anything there.
- on_gsm_ts_init(): the mechanism to trigger timeslot initialization is related
  to OML, while this action to take on init would pull in RSL dependencies.
utils/ and ipaccess/ each have a stubs.c file to implement these stubs. Tests
implement stubs inline where required.

>From src/utils/, src/ipaccess/ and tests/*/, link in .o files from osmo-bsc/.
In order for this to work, the osmo-bsc subdir must be built before the other
source trees. (An alternative would be to include the .c files as sources, but
that would re-compile them in every source tree. Not a large burden really, but
unless linking .o files gives problems, let's have the quicker build.)

Minor obvious cleanups creep in with this patch, I will not bother to name them
individually now unless code review asks me to.

Rationale:

1) libbsc has been separate to use it for osmo-nitb and osmo-bsc in the old
openbsc.git. This is no longer required, and spreading over libbsc and osmo-bsc
is distracting.

2) Recently, ridiculous linking requirements have made adding new functions
cumbersome, because libbsc has started depending on osmo-bsc/*.c
implementations: on gscon FSM and bssap functions. For example, neither
bs11_config nor ipaccess-config nor bts_test need handover_cfg or BSSMAP
message composition. It makes no sense to link the entire osmo-bsc to it, nor
do we want to keep adding stubs to each linking realm.

Change-Id: I36a586726f5818121abe54d25654819fc451d3bf
---
M configure.ac
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/bss.h
M include/osmocom/bsc/chan_alloc.h
D include/osmocom/bsc/common_bsc.h
M include/osmocom/bsc/gsm_data.h
M src/Makefile.am
M src/ipaccess/Makefile.am
M src/ipaccess/ipaccess-config.c
A src/ipaccess/stubs.c
D src/libbsc/Makefile.am
D src/libbsc/bsc_init.c
D src/libbsc/net_init.c
M src/osmo-bsc/Makefile.am
R src/osmo-bsc/a_reset.c
A src/osmo-bsc/abis_bs11.c
R src/osmo-bsc/abis_nm.c
R src/osmo-bsc/abis_nm_ipaccess.c
R src/osmo-bsc/abis_nm_vty.c
R src/osmo-bsc/abis_om2000.c
R src/osmo-bsc/abis_om2000_vty.c
R src/osmo-bsc/abis_rsl.c
R src/osmo-bsc/acc_ramp.c
R src/osmo-bsc/arfcn_range_encode.c
R src/osmo-bsc/bsc_api.c
R src/osmo-bsc/bsc_ctrl_commands.c
R src/osmo-bsc/bsc_ctrl_lookup.c
R src/osmo-bsc/bsc_dyn_ts.c
A src/osmo-bsc/bsc_init.c
R src/osmo-bsc/bsc_rf_ctrl.c
R src/osmo-bsc/bsc_rll.c
R src/osmo-bsc/bsc_subscr_conn_fsm.c
R src/osmo-bsc/bsc_subscriber.c
R src/osmo-bsc/bsc_vty.c
R src/osmo-bsc/bts_ericsson_rbs2000.c
R src/osmo-bsc/bts_init.c
R src/osmo-bsc/bts_ipaccess_nanobts.c
R src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c
R src/osmo-bsc/bts_nokia_site.c
R src/osmo-bsc/bts_siemens_bs11.c
R src/osmo-bsc/bts_sysmobts.c
R src/osmo-bsc/bts_unknown.c
R src/osmo-bsc/chan_alloc.c
R src/osmo-bsc/e1_config.c
R src/osmo-bsc/gsm_04_08_utils.c
R src/osmo-bsc/gsm_04_80_utils.c
R src/osmo-bsc/gsm_data.c
R src/osmo-bsc/handover_cfg.c
R src/osmo-bsc/handover_decision.c
R src/osmo-bsc/handover_decision_2.c
R src/osmo-bsc/handover_logic.c
R src/osmo-bsc/handover_vty.c
R src/osmo-bsc/meas_feed.c
R src/osmo-bsc/meas_rep.c
A src/osmo-bsc/net_init.c
R src/osmo-bsc/osmo_bsc_lcls.c
M src/osmo-bsc/osmo_bsc_main.c
R src/osmo-bsc/paging.c
R src/osmo-bsc/pcu_sock.c
R src/osmo-bsc/penalty_timers.c
R src/osmo-bsc/rest_octets.c
R src/osmo-bsc/system_information.c
M src/utils/Makefile.am
M src/utils/bs11_config.c
A src/utils/stubs.c
M tests/abis/Makefile.am
M tests/abis/abis_test.c
M tests/bsc/Makefile.am
M tests/bsc/bsc_test.c
M tests/gsm0408/Makefile.am
M tests/gsm0408/gsm0408_test.c
M tests/handover/Makefile.am
M tests/handover/handover_test.c
M tests/nanobts_omlattr/Makefile.am
M tests/nanobts_omlattr/nanobts_omlattr_test.c
M tests/subscr/Makefile.am
76 files changed, 1,060 insertions(+), 906 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/9481/4
-- 
To view, visit https://gerrit.osmocom.org/9481
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I36a586726f5818121abe54d25654819fc451d3bf
Gerrit-Change-Number: 9481
Gerrit-PatchSet: 4
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180607/b1df0286/attachment.htm>


More information about the gerrit-log mailing list