This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9439 ) Change subject: Introduce osmo_ss7_asp_rx_unknown() for handling unknown PPID/StreamID ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9439/1/src/osmo_ss7.c File src/osmo_ss7.c: https://gerrit.osmocom.org/#/c/9439/1/src/osmo_ss7.c@1923 PS1, Line 1923: __attribute__((weak)) > To be honest, it's the first time I see this, I was not aware it existed. […] weak symbols are used in virtually any microcontroller / bare metal project I'm familiar with. But then yes, those by their very nature don't require to be portable in any way, at least not across compilers. We also use it in libosmocore/src/sercomm.c already (which was originally from OsmocomBB and later moved in libosmocore to be able to use it in other contexts). The Linux kernel also uses them. But all in all, I agree, there's no need to rely on this, and having an explicit function pointer with setter-function is not a big effort. -- To view, visit https://gerrit.osmocom.org/9439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8616f914192000df0ec6547ff4ada80e0f9042a2 Gerrit-Change-Number: 9439 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 06 Jun 2018 09:54:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180606/77642680/attachment.htm>