This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9454 ) Change subject: Disconnect properly on errors so we can reconnect ...................................................................... Disconnect properly on errors so we can reconnect Change-Id: Id134be34a24e91a4c0b8a8d11cf4df9593dae687 --- M osysmon_ctrl.c 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/osysmon_ctrl.c b/osysmon_ctrl.c index 15521aa..25c2b4c 100644 --- a/osysmon_ctrl.c +++ b/osysmon_ctrl.c @@ -279,6 +279,15 @@ llist_for_each_entry(ccgv, &cc->get_vars, list) { char *value = simple_ctrl_get(cc->sch, ccgv->cfg.name); + /* FIXME: Distinguish between ERROR reply and + * connection issues */ + /* Close connection on error */ + if (!value) { + simple_ctrl_close(cc->sch); + cc->sch = NULL; + return 0; + } + value_node_add(vn_clnt, vn_clnt, ccgv->cfg.name, value); free(value); /* no talloc, this is from sscanf() */ } -- To view, visit https://gerrit.osmocom.org/9454 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id134be34a24e91a4c0b8a8d11cf4df9593dae687 Gerrit-Change-Number: 9454 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180605/26695cb7/attachment.htm>