Change in osmo-sysmon[master]: Remove unused last_value handling code

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/9452


Change subject: Remove unused last_value handling code
......................................................................

Remove unused last_value handling code

Change-Id: I14cc5883af8ae73bc462ed714ef38c8ee1444cc6
---
M osysmon_ctrl.c
1 file changed, 1 insertion(+), 16 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/52/9452/1

diff --git a/osysmon_ctrl.c b/osysmon_ctrl.c
index b13b13b..15521aa 100644
--- a/osysmon_ctrl.c
+++ b/osysmon_ctrl.c
@@ -63,8 +63,6 @@
 		/* display name, if any */
 		const char *display_name;
 	} cfg;
-	/* most recent value we received for this */
-	char *last_value;
 };
 
 static struct ctrl_client *ctrl_client_find(struct osysmon_state *os, const char *name)
@@ -275,27 +273,14 @@
 		cc->sch = simple_ctrl_open(cc, cc->cfg.remote_host, cc->cfg.remote_port, 1000);
 	/* abort, if that failed */
 	if (!cc->sch) {
-		llist_for_each_entry(ccgv, &cc->get_vars, list) {
-			if (ccgv->last_value) {
-				talloc_free(ccgv->last_value);
-				ccgv->last_value = talloc_strdup(ccgv, "<UNKNOWN>");
-			}
-		}
 		return -1;
 	}
 
 	llist_for_each_entry(ccgv, &cc->get_vars, list) {
 		char *value = simple_ctrl_get(cc->sch, ccgv->cfg.name);
-#if 0
-		if (ccgv->last_value) {
-			talloc_free(ccgv->last_value);
-			ccgv->last_value = NULL;
-		}
-		ccgv->last_value = value;
-#else
+
 		value_node_add(vn_clnt, vn_clnt, ccgv->cfg.name, value);
 		free(value); /* no talloc, this is from sscanf() */
-#endif
 	}
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/9452
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14cc5883af8ae73bc462ed714ef38c8ee1444cc6
Gerrit-Change-Number: 9452
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180605/478e911c/attachment.htm>