Change in osmo-hlr[master]: hlr_ussd.h: drop meaningless forward declaration

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jul 31 11:01:18 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10268 )

Change subject: hlr_ussd.h: drop meaningless forward declaration
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10268/1/src/hlr_ussd.h
File src/hlr_ussd.h:

https://gerrit.osmocom.org/#/c/10268/1/src/hlr_ussd.h@a9
PS1, Line 9: 
why is it meaningless?  This file does not include gsup_client.h and it uses 'struct osmo_gsup_conn *' below.  So I think the original code is correct?



-- 
To view, visit https://gerrit.osmocom.org/10268
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70a5c7c83c2356b779fb1ea7ffe07ccc1e279c22
Gerrit-Change-Number: 10268
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 31 Jul 2018 11:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180731/86662169/attachment.htm>


More information about the gerrit-log mailing list