Change in libosmocore[master]: ipa_ccm_idtag_parse*: Fix reported length value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jul 28 19:40:17 UTC 2018


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10216


Change subject: ipa_ccm_idtag_parse*: Fix reported length value
......................................................................

ipa_ccm_idtag_parse*: Fix reported length value

IPA CCM is using a somewhat weird TLV encoding scheme:
* 16bit length (of tag and value)
* 8bit tag
* value

Our existing code mapping the CCM to 'struct tlv_parse' used the plain
length value without accounting for the one-byte tag.

This patch ensures we only report the length of the "value" part,
excluding the tag.

Change-Id: I435aaa33605bd48635715a2c81aa2d231c1abf51
---
M src/gsm/ipa.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/16/10216/1

diff --git a/src/gsm/ipa.c b/src/gsm/ipa.c
index aecde83..f03bc38 100644
--- a/src/gsm/ipa.c
+++ b/src/gsm/ipa.c
@@ -128,7 +128,7 @@
 
 		DEBUGPC(DLMI, "%s='%s' ", ipa_ccm_idtag_name(t_tag), cur);
 
-		dec->lv[t_tag].len = t_len - len_offset;
+		dec->lv[t_tag].len = t_len - 1 - len_offset;
 		dec->lv[t_tag].val = cur;
 
 		cur += t_len - len_offset;

-- 
To view, visit https://gerrit.osmocom.org/10216
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I435aaa33605bd48635715a2c81aa2d231c1abf51
Gerrit-Change-Number: 10216
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180728/8d3e6be6/attachment.htm>


More information about the gerrit-log mailing list