This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10183 ) Change subject: BTS: fix: pad LAPDm frames before sending via L1CTL ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/10183/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/10183/2//COMMIT_MSG@23 PS2, Line 23: pad the frames automatically, but it doesn't and shouldn't. > I think OsmocomBB is padding the frames if they are too short, doesn't it? I think that may be where […] It actually does, but on the higher layers. So, on L1CTL we should have already padded frames. I also just checked Calypso firmware, and there are also no checks of the length, nor padding, so the firmware can also run into the heap overflow... https://gerrit.osmocom.org/#/c/10183/2/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/10183/2/bts/BTS_Tests.ttcn@3226 PS2, Line 3226: 02 > 0x2B Thanks! I just discovered that there is a function for doing that. I was looking for it in 'library/', but it's private and defined here... -- To view, visit https://gerrit.osmocom.org/10183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16cba4e4179456bebabf0638760af011a27fd333 Gerrit-Change-Number: 10183 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 27 Jul 2018 08:10:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180727/303e0255/attachment.htm>