Change in osmo-bts[master]: clear GPRS indicator in SI3 while PCU is disconnected

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10170 )

Change subject: clear GPRS indicator in SI3 while PCU is disconnected
......................................................................


Patch Set 1: Code-Review+1

(4 comments)

Can we share code with osmo-bsc rest_octets.[ch]? (by moving to libosmocore)

If not, the si3 decoding and encoding should probably have a C test.

https://gerrit.osmocom.org/#/c/10170/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/10170/1//COMMIT_MSG@10
PS1, Line 10: The BSC has no knowledge of the PCU connection state. Prevent MMs
MSs?


https://gerrit.osmocom.org/#/c/10170/1/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/10170/1/src/common/rsl.c@289
PS1, Line 289: struct gsm48_si3_rest {
would it make sense to move gsm48_si_ro_info from osmo-bsc to libosmocore?


https://gerrit.osmocom.org/#/c/10170/1/src/common/rsl.c@290
PS1, Line 290: 	uint8_t				sp;
why tabs?


https://gerrit.osmocom.org/#/c/10170/1/src/common/rsl.c@516
PS1, Line 516: 			if (!pcu_connected()) {
(the levels of nesting suggest a separate function)



-- 
To view, visit https://gerrit.osmocom.org/10170
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6f5c636c0fe098ee31c280d4572a3f8122b44b
Gerrit-Change-Number: 10170
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jul 2018 20:46:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180726/55a8b30e/attachment.htm>