Change in osmo-ttcn3-hacks[master]: msc: Fix random error of TC_cl3_rnd_payload

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Jul 26 10:03:50 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10166 )

Change subject: msc: Fix random error of TC_cl3_rnd_payload
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn
File msc/MSC_Tests.ttcn:

https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1159
PS1, Line 1159: 	// other fields beside l3info payload. So payl can only be 240 bytes
> The short answer was that before it was 256 for a max length of 255. […]
Oh returning <1 is not nice indeed. I think this situation (specially since you document 240 and then use 241) is worth a comment. I'm pretty sure if I see this in the future it will raise a concern that the code is wrong.

Maybe it'd be a good idea to have a function doing that in the library to avoid this kind of complexities, feel free do do it here, or in another commit now or in the future.



-- 
To view, visit https://gerrit.osmocom.org/10166
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7be33e261a11f03a80a6b770b6acf0a4be49b85b
Gerrit-Change-Number: 10166
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jul 2018 10:03:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180726/52ae7de0/attachment.htm>


More information about the gerrit-log mailing list