Change in osmo-ttcn3-hacks[master]: BTS: fix length of frames generated by f_TC_chan_act_encr

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Wed Jul 25 17:14:00 UTC 2018


Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/10159 )

Change subject: BTS: fix length of frames generated by f_TC_chan_act_encr
......................................................................

BTS: fix length of frames generated by f_TC_chan_act_encr

Since trxcon now drops L2 frames of an incorrect length, some
BTS tests which send unpadded frames with a short payload
have started to fail.

Extend the payload size generated by f_TC_chan_act_encr()
to make these tests pass again:

TC_chan_act_a51
TC_chan_act_a52
TC_chan_act_a53

Found by: Vadim Yanitskiy
Related: OS#3415

Change-Id: I0f9a40503a4ed4fce10d9655f845ac49d33f4041
---
M bts/BTS_Tests.ttcn
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 4f0f0ef..941be28 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3658,7 +3658,7 @@
 	/* now we actually need to transmit some data both ways to check if the encryption works */
 	var L1ctlDlMessage dl;
 
-	var octetstring l3 := f_rnd_octstring(16);
+	var octetstring l3 := f_rnd_octstring(20);
 	var RslLinkId link_id := valueof(ts_RslLinkID_DCCH(0));
 
 	/* send UNITDATA_REQ from BTS to MS and expect it to arrive */

-- 
To view, visit https://gerrit.osmocom.org/10159
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f9a40503a4ed4fce10d9655f845ac49d33f4041
Gerrit-Change-Number: 10159
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180725/acac6e40/attachment.htm>


More information about the gerrit-log mailing list